Add additional node metrics to monitor cpu throttling #8290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhan289
reviewed
Jan 5, 2021
Comment on lines
+508
to
+516
| 'elasticsearch.cgroup.cpu.stat.number_of_elapsed_periods': ( | ||
| 'gauge', | ||
| 'os.cgroup.cpu.stat.number_of_elapsed_periods', | ||
| ), | ||
| 'elasticsearch.cgroup.cpu.stat.number_of_times_throttled': ( | ||
| 'gauge', | ||
| 'os.cgroup.cpu.stat.number_of_times_throttled', | ||
| ), | ||
| 'elasticsearch.process.cpu.percent': ('gauge', 'process.cpu.percent'), |
There was a problem hiding this comment.
With these three new metrics, please also add them to https://github.com/DataDog/integrations-core/blob/master/elastic/metadata.csv
mgarabed
requested changes
Jan 6, 2021
elastic/metadata.csv
Outdated
Comment on lines
259
to
261
| elasticsearch.cgroup.cpu.stat.number_of_elapsed_periods,gauge,integer, The number of reporting periods that have elapsed | ||
| elasticsearch.cgroup.cpu.stat.number_of_times_throttled,gauge,integer, The number of times all tasks in the same cgroup as the Elasticsearch process have been throttled | ||
| elasticsearch.process.cpu.percent,gauge,integer, CPU usage in percent, or -1 if not known at the time the stats are computed |
There was a problem hiding this comment.
The CI reported an error with these lines, this should fix it:
Suggested change
| elasticsearch.cgroup.cpu.stat.number_of_elapsed_periods,gauge,integer, The number of reporting periods that have elapsed | |
| elasticsearch.cgroup.cpu.stat.number_of_times_throttled,gauge,integer, The number of times all tasks in the same cgroup as the Elasticsearch process have been throttled | |
| elasticsearch.process.cpu.percent,gauge,integer, CPU usage in percent, or -1 if not known at the time the stats are computed | |
| elasticsearch.cgroup.cpu.stat.number_of_elapsed_periods,gauge,,integer,,The number of reporting periods that have elapsed,0,elasticsearch,cgroup cpu stat | |
| elasticsearch.cgroup.cpu.stat.number_of_times_throttled,gauge,,integer,,The number of times all tasks in the same cgroup as the Elasticsearch process have been throttled,0,elasticsearch,cpu stat throttled | |
| elasticsearch.process.cpu.percent,gauge,,integer,,CPU usage in percent, or -1 if not known at the time the stats are computed,0,elasticsearch,process cpu percent |
There was a problem hiding this comment.
CI reported a similar error by saying "integer is an invalid unit_name." Is it ok to add "integer" into VALID_UNIT_NAMES in metadata.py ?
Co-authored-by: Mike Garabedian <mike@mercuryrising.net>
mgarabed
requested changes
Jan 7, 2021
Co-authored-by: Mike Garabedian <mike@mercuryrising.net>
mgarabed
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These metrics help people to monitor cpu throttling in the cluster
Motivation
We use Datadog for monitoring/alerting our Elasticsearch cluster which is managed by Elastic. It runs on GCP and we need to see how much the cgroup which Elasticsearch exists in uses cpu and whether cpu throttling has been increasing or not. These metrics provide that capability to everyone who needs similar stuff.
Additional Notes
No
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached