add docker.containers.{running|stopped}.total gauges #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/totalcontainergauge
branch
from
cba1328
to
7d8314e
Compare
xvello
force-pushed
the
xvello/totalcontainergauge
branch
from
7d8314e
to
1dfe897
Compare
xvello
changed the title
hkaj
reviewed
Nov 10, 2017
hkaj
requested changes
Nov 10, 2017
docker_daemon/CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| * [IMPROVEMENT] Add custom tags to all service checks. See [#782][] | |||
| * [IMPROVEMENT] Add docker memory soft limit metric. See [#760][] | |||
| * [IMPROVEMENT] Add docker.total-containers.running & docker.total-containers.stopped metrics. See [#859][] | |||
xvello
changed the title
hkaj
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summing
docker.containers.runningon hosts with high container churn leads to false values, as we never send zeroes. These new gauges benefit from client-side aggregation to be more accurate.Versioning
manifest.jsonCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.