Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config spec example consumer option default to display_default #8593

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Rename config spec example consumer option default to display_default #8593

merged 1 commit into from
Feb 11, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Feb 11, 2021

Motivation

The upcoming data model consumer will use the option default as the default value at runtime, which despite the name, currently does not mean that (see for example the vsphere change)

@ofek ofek requested review from a team as code owners February 11, 2021 01:25
@ofek ofek merged commit e6bce64 into master Feb 11, 2021
@ofek ofek deleted the ofek/cs-default branch February 11, 2021 14:28
github-actions bot pushed a commit that referenced this pull request Feb 11, 2021
@ofek
Rename config spec example consumer option default to `display_defa…
b1bfd1b 
…ult` (#8593) e6bce64
@AlexandreYang
Copy link
Member

AlexandreYang commented Feb 12, 2021 •
edited

changelog/Changed should only apply to ddev change, but integration should use a changelog/Fixed label.

The plan is to:

Step 1: release ddev with changelog/Changed to have a major version bump #8613
Step 2: change label to changelog/Fixed, so other integration with have patch version bump

cc @ofek @FlorianVeaux

@ChristineTChen ChristineTChen mentioned this pull request Mar 8, 2021
Merged
4 tasks
ian28223 added a commit that referenced this pull request Jul 21, 2021
@ian28223
use display_default instead of default
038efa5 
Ref: #8593
`display_default` should now be used to generate defaults file
@ian28223 ian28223 mentioned this pull request Jul 21, 2021
Merged
4 tasks
ian28223 added a commit that referenced this pull request Jul 23, 2021
@ian28223
keep default as initial fallback (+1 squashed commit)
457f83f 
Squashed commits:
[038efa5] use display_default instead of default
Ref: #8593
`display_default` should now be used to generate defaults file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

Assignees
No one assigned
Labels
dev/tooling documentation integration/cilium integration/cisco_aci integration/clickhouse integration/cloud_foundry_api integration/couch integration/datadog_checks_dev integration/disk integration/go_expvar integration/istio integration/kafka_consumer integration/marathon integration/mongo integration/mysql integration/network integration/nfsstat integration/nginx integration/postgres integration/process integration/redisdb integration/riakcs integration/sap_hana integration/snowflake integration/varnish integration/vsphere integration/win32_event_log integration/wmi_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofek @AlexandreYang @mx-psi