Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime configuration validation #8970

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

What does this PR do?

Adds config models from #8675

@ofek ofek requested a review from a team as a code owner March 22, 2021 17:41
@ofek ofek force-pushed the ofek/sync_config_models_postfix branch from 5edfde2 to c83bd50 Compare March 23, 2021 14:37
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
class Config:
allow_mutation = False

postfix_user: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required, default is root

postfix_user = self.init_config.get('postfix_user', 'root')

@ofek ofek force-pushed the ofek/sync_config_models_postfix branch from c83bd50 to 37b770f Compare June 11, 2021 15:34
@ofek ofek requested a review from a team as a code owner June 11, 2021 15:37
@ghost ghost added the documentation label Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #8970 (cfc0fe6) into master (2893fd5) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
mesos_master 90.62% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
postfix 88.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@ofek ofek merged commit c21c0d6 into master Jun 11, 2021
@ofek ofek deleted the ofek/sync_config_models_postfix branch June 11, 2021 15:55
github-actions bot pushed a commit that referenced this pull request Jun 11, 2021
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
* Sync config models

* address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants