-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime configuration validation #8970
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/sync_config_models_postfix
branch
from
March 23, 2021 14:37
5edfde2
to
c83bd50
Compare
coignetp
requested changes
Jun 11, 2021
class Config: | ||
allow_mutation = False | ||
|
||
postfix_user: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, default is root
postfix_user = self.init_config.get('postfix_user', 'root') |
ofek
force-pushed
the
ofek/sync_config_models_postfix
branch
from
June 11, 2021 15:34
c83bd50
to
37b770f
Compare
ghost
added
the
documentation
label
Jun 11, 2021
coignetp
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
github-actions bot
pushed a commit
that referenced
this pull request
Jun 11, 2021
* Sync config models * address c21c0d6
alexandre-normand
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Sync config models * address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds config models from #8675