Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime configuration validation #8982

Merged
merged 1 commit into from Sep 21, 2021
Merged

Add runtime configuration validation #8982

merged 1 commit into from Sep 21, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

What does this PR do?

Adds config models from #8675

@ofek ofek requested a review from a team as a code owner March 22, 2021 17:43
@ofek ofek force-pushed the ofek/sync_config_models_scylla branch from ca01344 to d4485ea Compare March 23, 2021 14:37
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
sarah-witt
sarah-witt reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is updated/passing

@ofek ofek force-pushed the ofek/sync_config_models_scylla branch from d4485ea to 90f5f9f Compare September 21, 2021 17:46
@codecov
Copy link

codecov bot commented Sep 21, 2021 •
edited

Codecov Report

Merging #8982 (90f5f9f) into master (64a766a) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
scylla 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit bc0262a into master Sep 21, 2021
@ofek ofek deleted the ofek/sync_config_models_scylla branch September 21, 2021 18:16
github-actions bot pushed a commit that referenced this pull request Sep 21, 2021
@ofek
Sync config models (#8982) bc0262a
7d9cd75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

Assignees
No one assigned
Labels
integration/scylla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ofek @sarah-witt