Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime configuration validation #8985

Merged
merged 1 commit into from May 19, 2021
Merged

Add runtime configuration validation #8985

merged 1 commit into from May 19, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Mar 22, 2021

What does this PR do?

Adds config models from #8675

@ofek ofek requested a review from a team as a code owner March 22, 2021 17:44
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch from 262eb4e to 0825a4d Compare March 23, 2021 14:37
@ofek ofek changed the title Sync config models Add runtime configuration validation Mar 23, 2021
hithwen
hithwen requested changes May 6, 2021
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate field

@ofek ofek mentioned this pull request May 13, 2021
Merged
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch 2 times, most recently from 36b7c75 to b5ed11b Compare May 17, 2021 14:40
@ofek ofek mentioned this pull request May 17, 2021
Merged
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch from b5ed11b to 24b7bc7 Compare May 18, 2021 01:38
@ofek ofek requested a review from a team as a code owner May 18, 2021 01:38
@ghost ghost added the documentation label May 18, 2021
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch 2 times, most recently from 40048d9 to f623bb5 Compare May 18, 2021 12:51
@ofek ofek mentioned this pull request May 18, 2021
Merged
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch from f623bb5 to e0c60dc Compare May 18, 2021 13:42
@ofek ofek force-pushed the ofek/sync_config_models_sonarqube branch from e0c60dc to 865b0f9 Compare May 18, 2021 14:49
@codecov
Copy link

codecov bot commented May 18, 2021 •
edited

Codecov Report

Merging #8985 (865b0f9) into master (90e3f2f) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
sonarqube 95.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ofek ofek merged commit a5389f9 into master May 19, 2021
@ofek ofek deleted the ofek/sync_config_models_sonarqube branch May 19, 2021 12:42
github-actions bot pushed a commit that referenced this pull request May 19, 2021
@ofek
Sync config models (#8985) a5389f9
ccb0e86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen requested changes

@luisgonzalex luisgonzalex luisgonzalex approved these changes

Assignees
No one assigned
Labels
documentation integration/sonarqube
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofek @hithwen @luisgonzalex