Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable new_gc_metrics JMX config option for new installations #9501

Merged
merged 2 commits into from
Jun 11, 2021
Merged

Enable new_gc_metrics JMX config option for new installations #9501

merged 2 commits into from
Jun 11, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Jun 10, 2021

Motivation

Match behavior of collect_default_metrics (see #9441) as we plan on changing the default value of both to true in a major version update

@ofek ofek requested review from a team as code owners June 10, 2021 16:05
@codecov
Copy link

codecov bot commented Jun 10, 2021 •
edited

Codecov Report

Merging #9501 (894bf5f) into master (f37cc3f) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Flag Coverage Δ
datadog_checks_dev 80.53% <0.00%> (-0.07%) ⬇️
sonarqube 95.69% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ruthnaebeck
ruthnaebeck previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

ChristineTChen
ChristineTChen previously approved these changes Jun 10, 2021
View reviewed changes
olivielpeau
olivielpeau previously approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ofek ofek merged commit 0ef4a3f into master Jun 11, 2021
@ofek ofek deleted the ofek/jmx branch June 11, 2021 13:02
alexandre-normand pushed a commit that referenced this pull request Jun 24, 2021
@ofek @alexandre-normand
Enable new_gc_metrics JMX config option for new installations (#9501)
1f274fe 
* Enable `new_gc_metrics` JMX config option for new installations

* fix tests
This was referenced Jul 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coignetp coignetp coignetp approved these changes

@olivielpeau olivielpeau olivielpeau left review comments

@ChristineTChen ChristineTChen ChristineTChen left review comments

@ruthnaebeck ruthnaebeck ruthnaebeck left review comments

Assignees
No one assigned
Labels
dev/tooling integration/activemq integration/cassandra integration/confluent_platform integration/datadog_checks_dev integration/hazelcast integration/hive integration/hivemq integration/ignite integration/jboss_wildfly integration/kafka integration/presto integration/solr integration/sonarqube integration/tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ofek @olivielpeau @ChristineTChen @ruthnaebeck @coignetp