Allow the use of the new OpenMetrics implementation #9588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtappa
reviewed
Jun 23, 2021
jtappa
previously approved these changes
Jun 23, 2021
kayayarai
previously approved these changes
Jun 28, 2021
hithwen
reviewed
Jun 29, 2021
ghost
added
changelog/no-changelog
integration/ambari
integration/aspdotnet
integration/cacti
integration/cassandra
integration/cassandra_nodetool
integration/cilium
integration/clickhouse
integration/consul
integration/consul_connect
integration/coredns
integration/couchbase
integration/couch
integration/datadog_checks_base
labels
Co-authored-by: Julia <611228+hithwen@users.noreply.github.com>
Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com>
ChristineTChen
force-pushed
the
cc/istio-v2
branch
from
9c925d0
to
db4e372
Compare
kayayarai
approved these changes
Aug 9, 2021
ofek
approved these changes
Aug 9, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Allow the use of the new OpenMetrics implementation * Add use_openmetrics option * Document service checks * Update config models * Remove unused prometheus url * Update compatibility for V2 * Refactor config logic * Add type overrides to be backwards compatible * Override namespace * Override namespace * Remove type_overrides * Add support for message metrics * Add metadata * Fix test * Remove legacy tests for EOL versions * Refactor test utils * Update istio/datadog_checks/istio/istio.py Co-authored-by: Julia <611228+hithwen@users.noreply.github.com> * remove unused function * Add comments for V2 tests * Refactor V2 test to new file * Fix license header * Add test with type overrides * Fix config models * Fix format for sc * Fix config models * Override prometheus * Fix style * Update istio/assets/configuration/spec.yaml Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> * Enable option by default Co-authored-by: Julia <611228+hithwen@users.noreply.github.com> Co-authored-by: Kari Halsted <12926135+kayayarai@users.noreply.github.com> f28ecce
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Istio integration with OpenmetricsBaseCheckV2.
Motivation
Better performance, especially for large payloads.
Simplify configuration by allowing both
istio_mesh_endpointandistiod_metricsto be enabled in the same instance.Additional Notes
This is behind a config flag
use_openmetricsV2 version does not support the various endpoints that are no longer supported in istio 1.5 and higher.
Istio 1.5 EOL https://istio.io/latest/news/support/announcing-1.5-eol/
Removed tests for older versions (1.0, 1.2) which have been EOL in 2019 https://istio.io/latest/news/support/announcing-1.2-eol/
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached