Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-resolve IP after a set duration #9699

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Re-resolve IP after a set duration #9699

merged 5 commits into from
Aug 4, 2021

Conversation

ian28223
Copy link
Contributor

What does this PR do?

Re-resolves the IP address of a given host after a set duration regardless if the previous IP still works.

Motivation

AGENT-6539

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ian28223 ian28223 requested review from a team as code owners July 14, 2021 06:06
@ghost ghost added the documentation label Jul 14, 2021
@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #9699 (ca3b1f6) into master (fd98ab6) will increase coverage by 0.00%.
The diff coverage is 86.11%.

Flag Coverage Δ
tcp_check 88.83% <86.11%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

hithwen
hithwen requested changes Jul 14, 2021
View reviewed changes
tcp_check/assets/configuration/spec.yaml Show resolved Hide resolved
tcp_check/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
@ian28223 ian28223 requested a review from hithwen July 14, 2021 11:57
kayayarai
kayayarai requested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs clarification edits

tcp_check/assets/configuration/spec.yaml Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/data/conf.yaml.example Outdated Show resolved Hide resolved
@ian28223 ian28223 force-pushed the ian.bucad/tcp_check_resolveip_duration branch from 0be9357 to 6ee9e2f Compare July 20, 2021 01:05
@ian28223 ian28223 force-pushed the ian.bucad/tcp_check_resolveip_duration branch from 6ee9e2f to 9fe8611 Compare July 26, 2021 23:27
hithwen
hithwen requested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Show resolved Hide resolved
@ian28223
Addressed review
342e4fc 
change also allows ip_cache_duration of 0 meaning resolve the IP every run.
@ian28223
add tests
337dd58
kayayarai
kayayarai previously approved these changes Jul 28, 2021
View reviewed changes
hithwen
hithwen requested changes Aug 4, 2021
View reviewed changes
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
tcp_check/datadog_checks/tcp_check/tcp_check.py Outdated Show resolved Hide resolved
@ian28223 ian28223 force-pushed the ian.bucad/tcp_check_resolveip_duration branch from 8d14f42 to ca3b1f6 Compare August 4, 2021 11:09
@hithwen hithwen merged commit b624f15 into master Aug 4, 2021
@hithwen hithwen deleted the ian.bucad/tcp_check_resolveip_duration branch August 4, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianVeaux FlorianVeaux FlorianVeaux left review comments

@hithwen hithwen hithwen approved these changes

@kayayarai kayayarai kayayarai left review comments

Assignees
No one assigned
Labels
documentation integration/tcp_check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ian28223 @hithwen @kayayarai @FlorianVeaux