Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neutrona integration #254

Merged
merged 34 commits into from
Feb 6, 2019
Merged

Add Neutrona integration #254

merged 34 commits into from
Feb 6, 2019

Conversation

DavidFlamini
Copy link
Contributor

What does this PR do?

Add Neutrona integration.

This check monitors Neutrona cloud connectivity services to:

  • Azure (ExpressRoute)

Motivation

Provide connectivity service metrics to Neutrona Cloud Connect customers.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes

N/A

@DavidFlamini
Copy link
Contributor Author

Hi guys, sorry I had to run on Friday and couldn't comment on this.

  • Travis CI is passing for py27 but failing for py36, but passes both py27 and py36 locally.
  • AppVeyor is failing at docker-compose, do we need to add docker-compose as a requirement somewhere?

Any help would be much appreciated.

Thanks!

@masci
Copy link
Contributor

masci commented Jan 7, 2019

@DavidFlamini I haven't checked this PR out yet but I can say Docker doesn't work on Appveyor, you might need to do something like https://github.com/DataDog/integrations-core/pull/2819/files#diff-3dbe8427233f0de207aa1c7de2fa968eR13

neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
neutrona/README.md Outdated Show resolved Hide resolved
ruthnaebeck and others added 8 commits January 7, 2019 14:29
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
metric prefixes were missing
neutrona/README.md Outdated Show resolved Hide resolved
@DavidFlamini
Copy link
Contributor Author

@DavidFlamini I haven't checked this PR out yet but I can say Docker doesn't work on Appveyor, you might need to do something like https://github.com/DataDog/integrations-core/pull/2819/files#diff-3dbe8427233f0de207aa1c7de2fa968eR13

@masci Thanks. I'm skipping the docker based tests on AppVeyor now. I also removed py36 from the envlist as Travis is failing to create the venv, locally both py27 and py36 are passing just fine.

@DavidFlamini
Copy link
Contributor Author

Hi guys, is there anything blocking this PR from merging?

@phrawzty
Copy link
Contributor

phrawzty commented Feb 4, 2019

Hi guys, is there anything blocking this PR from merging?

Hello @DavidFlamini! Thanks for checking in. I'll ping on our side and get this moving. 😄

@DavidFlamini
Copy link
Contributor Author

Hi guys, is there anything blocking this PR from merging?

Hello @DavidFlamini! Thanks for checking in. I'll ping on our side and get this moving. 😄

Great, thanks! 😃

Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

neutrona/tox.ini Outdated Show resolved Hide resolved
neutrona/datadog_checks/neutrona/neutrona.py Show resolved Hide resolved
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified tox & travis to properly run py3. Great job @DavidFlamini, thank you very much!

@ofek ofek merged commit 45c2d8d into DataDog:master Feb 6, 2019
@nmuesch nmuesch mentioned this pull request Mar 20, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants