-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Neutrona integration #254
Conversation
Hi guys, sorry I had to run on Friday and couldn't comment on this.
Any help would be much appreciated. Thanks! |
@DavidFlamini I haven't checked this PR out yet but I can say Docker doesn't work on Appveyor, you might need to do something like https://github.com/DataDog/integrations-core/pull/2819/files#diff-3dbe8427233f0de207aa1c7de2fa968eR13 |
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
Co-Authored-By: DavidFlamini <david@neutrona.com>
metric prefixes were missing
@masci Thanks. I'm skipping the docker based tests on AppVeyor now. I also removed py36 from the envlist as Travis is failing to create the venv, locally both py27 and py36 are passing just fine. |
Hi guys, is there anything blocking this PR from merging? |
Hello @DavidFlamini! Thanks for checking in. I'll ping on our side and get this moving. 😄 |
Great, thanks! 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified tox & travis to properly run py3. Great job @DavidFlamini, thank you very much!
What does this PR do?
Add Neutrona integration.
This check monitors Neutrona cloud connectivity services to:
Motivation
Provide connectivity service metrics to Neutrona Cloud Connect customers.
Review checklist
no-changelog
label attachedAdditional Notes
N/A