Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsn bug fix #79

Closed
wants to merge 1 commit into from
Closed

Conversation

himajp303
Copy link

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md

Additional Notes

Anything else we should know when reviewing?

Fixing dsn connection errors
@himajp303 himajp303 changed the title Patch 1 dsn bug fix Sep 4, 2017
@truthbk truthbk changed the base branch from master to contributor/oracle September 4, 2017 10:15
@truthbk
Copy link
Member

truthbk commented Sep 4, 2017

Hi @himajp303! Thanks for your contribution. We are actually in the process of adding the oracle integration to the integrations-core repository, see this PR: DataDog/integrations-core#680

That should be merged soon. Could you please add your Oracle integration contributions to that repo?

Thank you very much!

@himajp303
Copy link
Author

himajp303 commented Sep 4, 2017 via email

@jeremy-lq
Copy link
Member

@himajp303 I'm closing this PR as DataDog/integrations-core#680 has been merged. Thanks.

@jeremy-lq jeremy-lq closed this Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants