Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle] adding integration #680

Merged
merged 21 commits into from
Sep 14, 2017
Merged

[oracle] adding integration #680

merged 21 commits into from
Sep 14, 2017

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Aug 16, 2017

What does this PR do?

Adds the oracle integration.

Motivation

Customer demand.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Versioning

  • Bumped the version check in manifest.json
  • Updated CHANGELOG.md

Additional Notes

Requires instantclient libraries available and in the LD_LIBRARY_PATH at the host.

@truthbk
[oracle][travis] get CI kickstarted.
b68c777 
[oracle][travis] enable agreement switch...
@jeremy-lq jeremy-lq mentioned this pull request Aug 16, 2017
Closed
@truthbk
[oracle] cannot catch unimportated exception - be generic.
51e8bba 
[oracle][test] lower cx_Oracle dep, issue with version 6.0
This was referenced Aug 21, 2017
Closed
Closed
@truthbk truthbk added this to the 5.18 milestone Aug 21, 2017
@truthbk truthbk changed the title [oracle][WIP] adding integration [oracle] adding integration Aug 28, 2017
@truthbk
[oracle] updating README and manifest.
7fcc726 
[oracle] adding metadata, fixing typo.

[oracle] fix copyritten notices.
@truthbk truthbk mentioned this pull request Sep 4, 2017
Closed
2 tasks
@gmmeyer gmmeyer self-requested a review September 12, 2017 17:24
@gmmeyer gmmeyer self-assigned this Sep 12, 2017
gmmeyer
gmmeyer previously approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@gmmeyer gmmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not going to look closely through the sql files. The check itself is fine and the tests seem pretty good.

There's nothing here that jumps out at me as being a problem. I added a very minor nit, but otherwise I'm approving this!

oracle/check.py Outdated
'Temp Space Used': 'oracle.temp_space_used',
}

def __init__(self, name, init_config, agentConfig, instances=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: if you're just calling super you could presumably remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed!

@truthbk
Copy link
Member Author

truthbk commented Sep 14, 2017

Merging - previous review was approved, but adding the CHANGELOG dismissed the review.

@truthbk truthbk merged commit b5fb5bb into master Sep 14, 2017
@truthbk truthbk deleted the jaime/oracle branch September 14, 2017 10:31
@truthbk truthbk mentioned this pull request Sep 18, 2017
Merged
gml3ff pushed a commit that referenced this pull request May 14, 2020
@kbogtob
Merge pull request #680 from DataDog/kbogtob/release-version-4.0.1
a0ae694 
Release version 4.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmeyer gmmeyer gmmeyer left review comments

Assignees

@gmmeyer gmmeyer

Labels
None yet
Projects
None yet
Milestone
5.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@truthbk @gmmeyer @masci @dwjvaughan