-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent race condition in LivenessTracker #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔧 Report generated by pr-comment-scanbuild Scan-Build Report
Bug Summary
Reports
|
richardstartin
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Prevents a race condition leading to crash when a partially filled up tracking entry is accessed
Motivation:
Currently, the liveness tracking table is flushed under a shared lock. This allows for tracking part to add new elements in parallel, as they are run under shared lock as well. Most of the time this works fine, but if a table is being flushed and an entry is just partially filled in, with the
ref
set to non-null butframes
still not set, this will lead to SIGSEG.Additional Notes:
In addition to the change of locking mode, this PR contains a bunch of extra asserts and trivial changes to make the code more expressive and consistent.
Fixes #87
How to test the change?:
I was using the following command to provoke the crash
The crashed followed within 15 minutes without this patch. With this patch I don't observe the crash after more than 4 hours of runtime.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!