Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SSE4.1 ceilf when available and add badges to readme #288

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Apr 26, 2024

  • Use the improved version of ceilf for amd64 from WAF nginx-datadog#65
  • Add some badges to the readme
  • Run fuzzer on schedule and on push to master

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.05%. Comparing base (28e9752) to head (79597e3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   83.05%   83.05%           
=======================================
  Files         119      119           
  Lines        4744     4744           
  Branches     2249     2249           
=======================================
  Hits         3940     3940           
  Misses        307      307           
  Partials      497      497           
Flag Coverage Δ
waf_test 83.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anilm3 Anilm3 changed the title Use __builtin_ceilf and add badges to readme Use improved ceilf and add badges to readme Apr 26, 2024
@pr-commenter
Copy link

pr-commenter bot commented Apr 26, 2024

Benchmarks

Benchmark execution time: 2024-04-26 16:32:48

Comparing candidate commit e39a9be in PR branch anilm3/update-ceilf-with-builtin with baseline commit 28e9752 in branch master.

Found 11 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 0 unstable metrics.

scenario:bool_equals_matcher.random

  • 🟩 execution_time [-78.883µs; -76.952µs] or [-6.655%; -6.492%]

scenario:exact_match_matcher.random

  • 🟩 execution_time [-96.189µs; -95.497µs] or [-6.266%; -6.221%]

scenario:float_equals_matcher.random

  • 🟩 execution_time [-79.802µs; -78.793µs] or [-6.721%; -6.636%]

scenario:ip_match_matcher.random

  • 🟩 execution_time [-71.303µs; -70.259µs] or [-4.572%; -4.505%]

scenario:lowercase_transformer.random

  • 🟩 execution_time [-93.406µs; -92.334µs] or [-5.404%; -5.342%]

scenario:regex_match_matcher.case_insensitive_flag.random

  • 🟩 execution_time [-149.258µs; -148.709µs] or [-3.497%; -3.484%]

scenario:regex_match_matcher.case_insensitive_option.random

  • 🟩 execution_time [-143.132µs; -141.774µs] or [-3.353%; -3.322%]

scenario:regex_match_matcher.random

  • 🟩 execution_time [-107.321µs; -106.119µs] or [-5.377%; -5.317%]

scenario:signed_equals_matcher.random

  • 🟩 execution_time [-72.689µs; -71.220µs] or [-6.159%; -6.035%]

scenario:string_equals_matcher.random

  • 🟩 execution_time [-79.500µs; -78.599µs] or [-5.503%; -5.441%]

scenario:unsigned_equals_matcher.random

  • 🟩 execution_time [-72.996µs; -71.893µs] or [-6.179%; -6.086%]

@Anilm3 Anilm3 marked this pull request as ready for review April 29, 2024 08:59
@Anilm3 Anilm3 requested a review from a team as a code owner April 29, 2024 08:59
@Anilm3
Copy link
Collaborator Author

Anilm3 commented Apr 29, 2024

Note: I will add cpuid checks for SSE4.1 for the first ceilf call.

@Anilm3 Anilm3 changed the title Use improved ceilf and add badges to readme Use SSE4.1 ceilf when available and add badges to readme Apr 30, 2024
@Anilm3 Anilm3 merged commit 48c6909 into master Apr 30, 2024
34 of 35 checks passed
@Anilm3 Anilm3 deleted the anilm3/update-ceilf-with-builtin branch April 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants