Add uWSGI support #41
Conversation
example/README.md
Outdated
| @@ -12,6 +12,7 @@ services: | |||
| - `http` runs a NodeJS HTTP server that listens on port 8080. | |||
| - `fastcgi` runs a NodeJS FastCGI server that listens on port 8080. | |||
| - `grpc` runs a NodeJS gRPC server that listens on port 1337. | |||
| - `uwsgi` runs a uWSGI server using the `uwsgi` protocol and listens on port 8080. | |||
There was a problem hiding this comment.
For consistency, this could mention Python the way others have mentioned NodeJS
There was a problem hiding this comment.
Not at all. I guess it was before I added the new rule in .gitignore. Resolved in d475f16
| ;; ddtrace required options | ||
| enable-threads = 1 | ||
| lazy-apps = 1 | ||
| import=ddtrace.bootstrap.sitecustomize |
There was a problem hiding this comment.
It took me a couple of minutes to figure this out, because the spot where ddtrace is installed is quite subtle.
Maybe some additional comments would be helpful
There was a problem hiding this comment.
I added more informations. As a non native english speaker, any suggestion will be appreciated :) Resolved in d475f16
src/datadog_directive.cpp
Outdated
| const auto guard = defer([&]() { cf->args = old_args; }); | ||
|
|
||
| for (const std::string_view key : keys) { | ||
| // NOTE(@dmehala): uWSGI uses the same key header convention thant fastcgi |
There was a problem hiding this comment.
Brainfart 🤡 Thank you! Resolved in d475f16
src/datadog_directive.cpp
Outdated
|
|
||
| return static_cast<char *>(NGX_CONF_OK); | ||
| } catch (const std::exception &e) { | ||
| ngx_log_error(NGX_LOG_ERR, cf->log, 0, "datadog_grpc_propagate_context failed: %s", e.what()); |
There was a problem hiding this comment.
Good catch. Fixed in d475f16
- Add uWSGI service for testing and as an example - Add propagation tests for uwsgi directives - Update example/README.md - Ignore *.pyc - Mention uwsgi_pass in the docs for datadog_proxy_directive Resolves #38
dmehala
force-pushed
the
dmehala/uwsgi
branch
from
8fc88ca
to
dea4eb9
Compare
This PR add support for uWSGI. When
uwsgi_passdirectives are encountered, the module automatically propagate traces.Content:
Resolves #38