Enable jmx receiver #4067
Merged
Enable jmx receiver #4067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackjmr
force-pushed
the
mackjmr/add-jmx-receiver-staging
branch
from
dccbe6c
to
ef5fcb3
Compare
|
@dineshg13 can you please take a look ? |
dineshg13
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a deployment collector pointed to the daemonset collector on the same host.
This Deployment collector has:
This needs to be done in a deployment, rather than adding the receivers to the daemonset, as if we were to add the receiver to the daemonset each collector agent would pull the same data, leading to duplicate metrics.
Related demo PR DataDog/opentelemetry-demo#16.