Avoid n^2 complexity during decoding #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overall package sizeSelf size: 165.24 kB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
`push` using `Array.concat` creates a new copy of the array for each inserted element and leads to n^2 complexity when decoding arrays. For pprof with large numbers of samples, this quickly leads to very long decoding (>1 min) compared to ~1s with this change.
nsavoire
force-pushed
the
nsavoire/improve_decode
branch
from
4613672
to
fd5f5a6
Compare
Qard
approved these changes
Feb 23, 2023
nsavoire
added a commit
that referenced
this pull request
Feb 24, 2023
`push` using `Array.concat` creates a new copy of the array for each inserted element and leads to n^2 complexity when decoding arrays. For pprof with large numbers of samples, this quickly leads to very long decoding (>1 min) compared to ~1s with this change.
nsavoire
added a commit
that referenced
this pull request
Feb 27, 2023
* Avoid n^2 complexity during decoding (#12) `push` using `Array.concat` creates a new copy of the array for each inserted element and leads to n^2 complexity when decoding arrays. For pprof with large numbers of samples, this quickly leads to very long decoding (>1 min) compared to ~1s with this change. * Add some interoperability tests with protobufjs (#13) Check that profiles encoded with pprof-format can be decoded by protobufjs and that pprof-format can decode profiles encoded with protobufjs. * v2.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushusingArray.concatcreates a new copy of the array for each inserted element and leads to n^2 complexity when decoding arrays. For pprof with large numbers of samples, this quickly leads to very long decoding (>1 min) compared to ~1s with this change.