Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid n^2 complexity during decoding #12

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Avoid n^2 complexity during decoding #12

merged 1 commit into from
Feb 24, 2023

Commits on Feb 22, 2023

  1. Avoid n^2 complexity during decoding 

    `push` using `Array.concat` creates a new copy of the array for each
inserted element and leads to n^2 complexity when decoding arrays.
For pprof with large numbers of samples, this quickly leads to very long
decoding (>1 min) compared to ~1s with this change.
    @nsavoire
    nsavoire committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fd5f5a6 View commit details
    Browse the repository at this point in the history