Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Datadog-Container-ID is not empty if present #2021

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

cbeauchesne
Copy link
Collaborator

Motivation

Datadog-Container-ID header should not be an empty string

Changes

Test asserting that Datadog-Container-ID is not empty

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
    • To R&P team: locally build and push the image to hub.docker.com
  • A scenario is added (or removed)?
    • Get a review from R&P team
    • Once merged, add (or remove) it in system-test-dasboard nightly

@cbeauchesne cbeauchesne marked this pull request as ready for review January 16, 2024 09:55
@cbeauchesne cbeauchesne requested review from a team as code owners January 16, 2024 09:55
@cbeauchesne cbeauchesne merged commit 17e45a8 into main Jan 16, 2024
157 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/datadog-container-id branch January 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants