Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/telemetry: do not send empty container and entity headers #2506

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Do not send container and entity ID headers if empty. It's already the case for profiling, dsm and tracing transport but the telemetry client was an anomaly.

Ideally, we should have a shared transport code that takes care of this.

Motivation

Fixes DataDog/system-tests#2021

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@ahmed-mez ahmed-mez requested a review from a team as a code owner January 16, 2024 10:28
@pr-commenter
Copy link

pr-commenter bot commented Jan 16, 2024

Benchmarks

Benchmark execution time: 2024-01-16 10:43:06

Comparing candidate commit 0c5ea05 in PR branch ahmed/fix-telmemetry-headers with baseline commit 7d7770f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

Copy link
Contributor

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmed-mez
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 16, 2024

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on slack #ci-interfaces with those details!

@ahmed-mez
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 16, 2024

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on slack #ci-interfaces with those details!

@darccio darccio merged commit 83844d4 into main Jan 16, 2024
154 checks passed
@darccio darccio deleted the ahmed/fix-telmemetry-headers branch January 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants