[datadog_synthetics_test] Add default value to http_version
#2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
force-pushed
the
corentin.girard/SYNTH-14142/default-http-version-to-any
branch
from
6185c3d
to
0850731
Compare
Drarig29
changed the title
http_versionhttp_version
Drarig29
force-pushed
the
corentin.girard/SYNTH-14142/default-http-version-to-any
branch
from
770136e
to
0b7716f
Compare
Drarig29
changed the base branch from
master
to
corentin.girard/SYNTH-14355/multistep-grpc-step
Drarig29
force-pushed
the
corentin.girard/SYNTH-14142/default-http-version-to-any
branch
from
0b7716f
to
65a3907
Compare
Drarig29
changed the title
http_versionhttp_version
Base automatically changed from
corentin.girard/SYNTH-14355/multistep-grpc-step
to
master
July 3, 2024 20:34
nkzou
force-pushed
the
corentin.girard/SYNTH-14142/default-http-version-to-any
branch
from
65a3907
to
e004591
Compare
urseberry
previously approved these changes
Jul 3, 2024
| @@ -730,7 +730,7 @@ Optional: | |||
| - `dns_server_port` (Number) DNS server port to use for DNS tests. | |||
| - `follow_redirects` (Boolean) Determines whether or not the API HTTP test should follow redirects. | |||
| - `host` (String) Host name to perform the test with. | |||
| - `http_version` (String) HTTP version to use for an HTTP request in an API test or step. Valid values are `http1`, `http2`, `any`. | |||
| - `http_version` (String) HTTP version to use for an HTTP request in an API test or step. Valid values are `http1`, `http2`, `any`. Defaults to `"any"`. | |||
There was a problem hiding this comment.
Suggested change
| - `http_version` (String) HTTP version to use for an HTTP request in an API test or step. Valid values are `http1`, `http2`, `any`. Defaults to `"any"`. | |
| - `http_version` (String) HTTP version to use for an HTTP request in an API test or step. Valid values are `http1`, `http2`, `any`. Defaults to `any`. |
nkzou
approved these changes
Jul 5, 2024
bharling
pushed a commit
to bharling/terraform-provider-datadog
that referenced
this pull request
Jul 8, 2024
…g#2406) * Fix location of `http_version` * Add a default value for `httpVersion` * update cassettes * make docs * update monitor test that uses a synthetics test * deprecate request_defintion.http_version instead of removing it --------- Co-authored-by: Kevin Zou <kevin.zou@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR stack, here is how it's organized:
unarygRPC steps in multistep API tests #2445renotify_intervaldrift when saving from UI #2457http_version#2406 (← you are here)request_definition.timeoutdefault value #2459This PR adds sets a default value for
http_versionfor both: