Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v20.0.1 Approved #727

Merged
merged 27 commits into from Feb 10, 2023
Merged

Conversation

davidtauriello
Copy link
Contributor

Changes:

  • Update dqc_0043 to handle add back of the loss on sale of disc ops.
  • Update dqc_0145 for additional exceptions
  • Increment version and recompile ruleset .zip files
  • Update travis-run.sh to use XULE 23379.2 version (NB: version 20 is the last release for this version of XULE)

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

campbellpryde and others added 27 commits January 26, 2023 16:51
Fixed CF add back calc of disc ops , updated 135 to handle derivative assets and derivative liabilities.
Updated the rules to address extension elements in the calculation.
Now handles where values do not add and calc does not add an extension.
Updated effective daye for rule 49.
Now handles where is an add back of the loss on sale of disc ops.
- modify script to use specific release; this allows for multiple XULE releases to be available.
- v20 of the DQC is the last release that will use XULE 23379.
davidtauriello added a commit that referenced this pull request Feb 10, 2023
* Update for v20.0.1 Approved (#725)

* Updated rule 43

Now handles where is an add back of the loss on sale of disc ops.

* Updated rule 145 for exceptions

* Updated version number for fix to 145 and 43

* Updated rules for Sonny Chnages

---------

Co-authored-by: Campbell

* Update v20.0.1 Approved (#727)

* Updated rule 43

Now handles where is an add back of the loss on sale of disc ops.

* Updated rule 145 for exceptions

* Updated version number for fix to 145 and 43

* Updated rules for Sonny Chnages

* Update travis-run.sh

- modify script to use specific release; this allows for multiple XULE releases to be available.
- v20 of the DQC is the last release that will use XULE 23379.

---------

Co-authored-by: Campbell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants