Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for v20.0.1 Approved #728

Merged
merged 687 commits into from
Feb 10, 2023
Merged

Merge for v20.0.1 Approved #728

merged 687 commits into from
Feb 10, 2023

Conversation

davidtauriello
Copy link
Contributor

Changes:

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

campbellpryde and others added 30 commits September 19, 2022 16:40
- filter for dqc_0081 and dqc_0139
- dqc_0011
- dqc_0080
- dqc_0011
- dqc_0080
* Update unit tests for v19

- dqc_0011
- dqc_0080

* Update DQC.IFRS.0080_lbk-ifrs-2019.xml

* Updated Data Quality Checks.

Co-authored-by: Campbell
campbellpryde and others added 29 commits January 18, 2023 12:31
commit b696d51
Merge: d7dc73d aa702f6
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Tue Jan 17 16:50:33 2023 -0500

    Merge branch 'dt-v20' into v20

commit aa702f6
Merge: d7dc73d 6550c0d
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Tue Jan 17 16:50:02 2023 -0500

    Update v20

    - dqc_0140 update for tolerance
    - copyright throughout

commit d7dc73d
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Thu Jan 5 11:04:01 2023 -0500

    Update DQC_0135.md

    - updated message for cases when financial statement captions are not used where amounts appear

commit 627f299
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Thu Dec 15 12:16:02 2022 -0500

    Update DQC_0146.md

    - update rule function to note conditions under which the rule will not be triggered.

commit 64690af
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Tue Dec 6 15:33:27 2022 -0500

    Update DQC_0135.md

commit ca76b8a
Author: David Tauriello <david.tauriello@xbrl.us>
Date:   Wed Nov 23 16:08:44 2022 -0500

    Update v20 Public Exposure (#708)

    * Update to Arelle 2.1.4

    * Updated rule 5 and 6 not to fire in cases where there are two document period end dates.

    * Updated rule 141 to match by class

    * Updated version 20 rules

    * Updated V20

    * Update .travis.yml

    - filter for updated rules

    * Update .travis.yml

    * Update DQC.US.0141.9863_bhlb-us-2021.xml

    * Update travis-run.sh

    Co-authored-by: Campbell
- update dqc_0140 tolerance
- update dqc_0148 rule number (and corresponding unit tests)
- update dqc_0015 effective dates
- add UGT 2023
* Update from v20 xule.dqc

- update dqc_0140 tolerance
- update dqc_0148 rule number (and corresponding unit tests)
- update dqc_0015 effective dates
- add UGT 2023
* Updated rule 1 for missing base member

* fixed us-gaap case

* Updated V20 for change to rule 1

Co-authored-by: Campbell
- Fix typo

Update .travis.yml
* Updated to handle differences in subtotal in cash flows.

* Update DQC_0043.xule

* Updated rule 135

* Updated V20 for changes in rule 43 and updates to 135 for derivatives

Fixed CF add back calc of disc ops , updated 135 to handle derivative assets and derivative liabilities.

* Update DQC_0043.xule

* Updated V20 for all changes for 135 and 43

* Updated 2023 taxonomy in V21 for changes

* Updated rule 140 to address extensions

Updated the rules to address extension elements in the calculation.

* Updated version for V20

* Updated V20

* Update .travis.yml

-- full run for approved v20.0.0

* Update resources.xule from CP xule.dqc

 - fix branch reference

* Update rule submission forms

 - approved v20 with effective date

* Updated rule 140 for 2021 and 2022

Now handles where values do not add and calc does not add an extension.

* Update rule 140 for 2023 so can cherry pick seperately

* Fixed 140 issue

---------

Co-authored-by: Campbell
- no logic changes (copyright, effective date)
* Updated rule 43

Now handles where is an add back of the loss on sale of disc ops.

* Updated rule 145 for exceptions

* Updated version number for fix to 145 and 43

* Updated rules for Sonny Chnages

---------

Co-authored-by: Campbell
* Updated rule 43

Now handles where is an add back of the loss on sale of disc ops.

* Updated rule 145 for exceptions

* Updated version number for fix to 145 and 43

* Updated rules for Sonny Chnages

* Update travis-run.sh

- modify script to use specific release; this allows for multiple XULE releases to be available.
- v20 of the DQC is the last release that will use XULE 23379.

---------

Co-authored-by: Campbell
@davidtauriello davidtauriello merged commit 09e51c3 into master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants