Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge for v23.0.5 Approved #810

Merged
merged 690 commits into from Feb 21, 2024
Merged

Merge for v23.0.5 Approved #810

merged 690 commits into from Feb 21, 2024

Conversation

davidtauriello
Copy link
Contributor

Changes:

Pull request process

  • Full description of changes provided above.
  • Reviewed by another person. (+1)
  • If this is a code change, reviewed by a second person. (+1)
  • QA'd to the specifications listed here. Documentation only changes do not require the formal code quality assurance process. (+10)
Once checklist is complete, @campbellpryde @marcward @davidtauriello please review for merge.

davidtauriello and others added 30 commits November 6, 2023 20:34
Updated rule description from calculation to presentation.
Removed invalid description at the top of the rule.
- fix symlink
- version v23.0.0RC1
- run all except dqc_0167
Updated rule to improve performance potentially
Added rule for 170 based on feed back from Shelly Wavrin.
- fixes for dqc_0167, dqc_0170 and dqc_0176
- remove non-negs
- confirming compile
- ESEF rulesets are not recompiled
- dqc_0080 changes
- dqc_0159, dqc_0167, dqc_0169
davidtauriello and others added 29 commits February 9, 2024 16:51
Arelle 2.23.1 XULE 23694.1
- Arelle 2.23.1
- create variable $PYTHON_VERSION
- Arelle 2.23.1 XULE 23694
- fix PYTHON_VERSION variable
* Updated rule 0168 to allow an opt out

Can use element TaxReconciliationNotRequired

* Updated rule 176 to handle the F1 report.

* Updated rule 118 to fix min error.

* Recompile ruleset .zip files

Arelle 2.23.1 XULE 23694.1

* Updated rule 118 to fix min error.

* Removed potential case conflict

* Update .travis.yml and .sh

- Arelle 2.23.1
- create variable $PYTHON_VERSION

* Fixed missing constant in 2020 ruleset

* Updated 166 to be consistent

* Recompile ruleset .zip files v23.0.3

- Arelle 2.23.1 XULE 23694

* Update .travis.yml

- fix PYTHON_VERSION variable

* Update test cases for changes dqc_0118 and dqc_0168

---------

Co-authored-by: campbellpryde
- exclude github workflows and build commands
* Updated rule 170 to exclude 20-F

* Added 10-Q to rule 170

* Updated date comparison

* Updated compiled

* Increment version and recompile ruleset .zip files

- Arelle 2.23.1 XULE 23722

---------

Co-authored-by: campbellpryde
@davidtauriello davidtauriello merged commit 16760da into master Feb 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants