Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Show no match when row count diff selection no match #367

Conversation

wcchang1115
Copy link
Collaborator

@wcchang1115 wcchang1115 commented Jun 28, 2024

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:
Hint user there's no node matched instead of empty result.

Which issue(s) this PR fixes:
DRC-508

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
Copy link

linear bot commented Jun 28, 2024

@wcchang1115 wcchang1115 marked this pull request as ready for review June 28, 2024 07:28
@wcchang1115 wcchang1115 merged commit 5aadb27 into main Jun 28, 2024
3 checks passed
@wcchang1115 wcchang1115 deleted the feature/drc-508-support-node-selector-in-row-count-checks-no-match branch June 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant