Switch to GitHub Actions for CI and Deployment #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move to GitHub Actions for CI and Deployment, as recommended by tidyverse / r-lib teams GHA provides more concurrent builds, longer build time limits, and smoother integration with GitHub - Remove .travis.yml and replicate logic in .github/workflows/check.yml - Tweaks to .gitignore and .Rbuildignore as needed
- Add packages used for testing to Suggests
- Check scalar-ness before checking positivity to avoid inappropriate logical recycling
- Add useDynLib call to NAMESPACE stump to avoid triggering error from .onLoad methods - Remove roxygen note from DESCRIPTION file
- Declare unnesting columns explicitly, as required by new versions of tidyr
- Per CRAN rules, update ArXiv link format - Per CRAN rules, don't include package name in description
- Explicitly name sp.path object in sparsity analysis (sp.path is the indicator of edge fusions) so as_tibble() doesn't need to automatically name (which throws a warning)
- Change NA tests to anyNA to ensure a scalar value in if() statements - Use inherits instead of class() == - Use identical instead of == to avoid possible length problem - Fix logical recycling error in cbass.R
michaelweylandt
force-pushed
the
mw/switch_ci
branch
from
ba0267a
to
51af6f6
Compare
- This is failing on GitHub CI with the error message:
argument 'fps' must be a factor of 100
(coming from the magick package) but it succeeds locally.
CI should be installing the (preferred) gifski renderer so
it's unclear why ImageMagick is being used at all, but
it's not a blocker for now.
- Add check for autodeployment from `develop` branch only (not PRs)
- Move build status badge from TravisCI to GitHub Actions - Remove AppVeyor Badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to GitHub Actions for CI and Deployment, as recommended
by tidyverse / r-lib teams
GHA provides more concurrent builds, longer build time limits,
and smoother integration with GitHub
Remove .travis.yml and replicate logic in .github/workflows/check.yml
Tweaks to .gitignore and .Rbuildignore as needed