-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMS] Everything is a Multi-lingual Topic #431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This PR contains many breaking changes, including a full data structure reorg, database restructuring, and update to Blueprint 3 (via the latest
canon-core
).This PR includes a number of changes:
Moving away from the traditional Profile -> Section -> Topic hierarchy, this PR takes an "Everything is a Topic" approach. This means that profiles are actually quite small now - containing only generators, materalizers, and a title. Everything else, sections, footnotes, topics, vizes - these are all special cases/templates of the generic "Topic," and are organized in an ordered list like a website (as opposed to strictly hierarchically).
Most every entity is now multi-lingual. This required the creation of corollary
content
tables that contain translated content, controlled by theCANON_LANGUAGES
environment variable. API endpoints now accept a&locale=<locale>
parameter to fetch content in the given locale, falling back toCANON_LANGUAGE_DEFAULT
if fields are missing.Update to
canon-core 17.4
. The most "breaking" part of this upgrade is the jump from blueprint 1.x to blueprint 3.x (though moving to react 16 caused a few blips as well). I have run both migration scripts and reorganized all labs components and moved allpt-
classes tobp3-
.