Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple example added. #8

Merged
merged 2 commits into from
Sep 9, 2013
Merged

Simple example added. #8

merged 2 commits into from
Sep 9, 2013

Conversation

drug007
Copy link
Contributor

@drug007 drug007 commented Sep 8, 2013

Simple example added. Also new configuration for dub added - to install all dependencies, build and run the example you just use dub like:
dub run --config=example

I'm not sure my skills, so check my english and review code too.

@Dav1dde
Copy link
Owner

Dav1dde commented Sep 8, 2013

I will look into this tomorrow a bit more.
I really like the Shader-Documentation, I think I never really mention how they are parsed. What you added to the readme should also be added to the index.d. I think the text needs some rewording though, I'll see if I can get a native speaker read over it, maybe it's just me.

I don't like these globals in the Example, either put them into main or make the whole application a class.

Not sure about this DUB thing, but does it make sense to add the example to the main DUB file? I don't think anyone wants to use the example, maybe include it in the readme as "you could use it like this ...".

Thanks for the work you put in glamour, much appreciated!

@drug007
Copy link
Contributor Author

drug007 commented Sep 9, 2013

I refactored the example - it uses classes now.
I don't know ddoc specs, so I skip this step.
What about adding the example to the main DUB file - I think like a newbie. Newbie both to OpenGL 3.2 core stuff and to glamour. And I made the example because if I had it when I started learning it definitely saved my time. Of course seasoned users won't use the example, but there are newbies also. Moreover I'm pretty sure it would be cool to have some tutorial.

@Dav1dde
Copy link
Owner

Dav1dde commented Sep 9, 2013

The example looks really good now!
And my concerns about the build are baseless. I will add the missing section to the index.d later.

Dav1dde added a commit that referenced this pull request Sep 9, 2013
@Dav1dde Dav1dde merged commit 0a49f69 into Dav1dde:master Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants