Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check first Index value #171

Merged
merged 4 commits into from
Nov 11, 2020
Merged

check first Index value #171

merged 4 commits into from
Nov 11, 2020

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Nov 10, 2020

Fix for reported bug #170. A library internal error occurs when a user modifies history length after it was previously used or cleaned. The fix allows the internal cleaner to recompose an internal Index if it detects a bad starting value, which can occur if you decide to reuse and cut down history with methods such as TakeLast.

I'm also adding an undocumented history.RemoveIndex() extension that will allow a user to remove the internal index from a previously utilized or cleaned history. With this fix, you would not need this extension; however, I'm adding it in case there are unidentified reasons for a user to need to remove the internal indexing.

@DaveSkender DaveSkender merged commit 7dc877d into master Nov 11, 2020
@DaveSkender DaveSkender deleted the fix-index-check branch November 11, 2020 01:27
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant