Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove internal index #182

Merged
merged 38 commits into from
Nov 17, 2020
Merged

refactor: remove internal index #182

merged 38 commits into from
Nov 17, 2020

Conversation

DaveSkender
Copy link
Owner

@DaveSkender DaveSkender commented Nov 16, 2020

Removing internal redundant indexing as part of ongoing continuous improvement, per AB#763. The internal Index has been problematic in its current implementation for some unexpected use cases. This resolves issues #180 and #170.

To do:

  • remove index from indicator classes
  • remove Index from Quote class
  • replace the use of Cleaner in indicators with simpler Resorter
  • keep PrepareHistory for optional advanced cleaning (to make it optional), also to avoid breaking change

@DaveSkender DaveSkender merged commit 5035db5 into master Nov 17, 2020
@DaveSkender DaveSkender deleted the remove-index branch November 17, 2020 04:37
@github-actions
Copy link

This Pull Request has been automatically locked since there has not been any recent activity after it was closed. Please open a new Issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant