Skip to content

Commit

Permalink
add missing jacobian arrays to netcdf ozone diagnostic file (NOAA-EMC…
Browse files Browse the repository at this point in the history
…#618) (NOAA-EMC#619)

**Description**
PR NOAA-EMC#591 removed jacobian information from the netcdf ozone diagnostic
file. This caused `enkf.x` to crash. This PR adds the removed ozone
jacobian arrays back to the netcdf ozone diagnostic file.

Fixes NOAA-EMC#618

**Type of change**
- [x] Bug fix (non-breaking change which fixes an issue)


**How Has This Been Tested?**
The revised code was tested in the 20210814 18 gdas cycle of a C192L127
enkf parallel. The updated `gsi.x` created an oznstat file which was
successfully processed by `enkf.x`.
  
**Checklist**
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] New and existing tests pass with my changes
  • Loading branch information
RussTreadon-NOAA committed Sep 12, 2023
1 parent d7ac706 commit a6515bd
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/gsi/setupoz.f90
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,9 @@ subroutine setupozlay(obsLL,odiagLL,lunin,mype,stats_oz,nlevs,nreal,nobs,&
call nc_diag_metadata("Row_Anomaly_Index", sngl(rmiss) )
endif
if (save_jacobian) then
call fullarray(dhx_dx, dhx_dx_array)
call nc_diag_data2d("Observation_Operator_Jacobian", dhx_dx_array)
call nc_diag_data2d("Observation_Operator_Jacobian_stind", dhx_dx%st_ind)
call nc_diag_data2d("Observation_Operator_Jacobian_endind", dhx_dx%end_ind)
call nc_diag_data2d("Observation_Operator_Jacobian_val", real(dhx_dx%val,r_single))
endif
!if (wrtgeovals) then
! call nc_diag_data2d("mole_fraction_of_ozone_in_air", sngl(constoz*ozgestmp))
Expand Down

0 comments on commit a6515bd

Please sign in to comment.