Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow glk_window_get_arrangement to take NULL arguments #1

Merged
merged 1 commit into from
Feb 19, 2014

Conversation

EmacsUser
Copy link
Contributor

I ran into what seems to be a bug in Windows-Glk. According to Section 1.9 of the Glk Specification, "Other API Conventions",

Some functions have pointer arguments, acting as "variable" or "reference" arguments; the function’s intent is to return some value in the space pointed to by the argument. Unless the function says otherwise, it is legal to pass NULL to indicate that you do not care about that value.

The documentation for glk_window_get_arrangement does not say otherwise, but Windows-Glk still assumes that all three pointers are non-null. This commit removes that assumption.

….9 of the Glk Specification, "Other API Conventions".
DavidKinder pushed a commit that referenced this pull request Feb 19, 2014
Allow glk_window_get_arrangement to take NULL arguments
@DavidKinder DavidKinder merged commit 5e15595 into DavidKinder:master Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants