Interpreter Sniffing: is_detectCocoaGlk crashes WinGit

[curiousdannii]

When used with Kerkerkruip is_detectCocoaGlk crashes WinGit.

[EmacsUser]

Huh. I'll look into it.

[EmacsUser]

Okay, I got my hands on a Windows box and confirmed the bug. Now I just have to remember how to debug things in Windows...

[EmacsUser]

After making the mistake of shutting down the computer, at which point it decided to install 79 updates, I finally got impatient and found the bug by code inspection instead.

Per Section 1.9 of the Glk Spec:

Some functions have pointer arguments, acting as "variable" or "reference" arguments; the function’s intent is to return some value in the space pointed to by the argument. Unless the function says otherwise, it is legal to pass NULL to indicate that you do not care about that value.

However, https://github.com/DavidKinder/Windows-Glk/blob/master/GlkDll/GlkWindow.cpp#L1122 has no nonnullness checks.

I have to travel for a bit, but I'll get throw-away arrays in as a workaround and send David a bug report once I arrive.

[EmacsUser]

Okay, DavidKinder/Windows-Glk#1 is in; workaround shortly.

[EmacsUser]

Okay, now I have the unfortunate problem of not being able to get to a Windows machine again until Monday. Would somebody be willing to verify this fix?

[curiousdannii]

Yep it works! Thanks for figuring this out!