Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support ReactNative #44

Merged
merged 4 commits into from
Apr 21, 2020
Merged

Conversation

chrisdrackett
Copy link
Contributor

No description provided.

@chrisdrackett
Copy link
Contributor Author

Not sure if this is the best way forward vs. just treating React Native like a server implementation.

@chrisdrackett chrisdrackett marked this pull request as ready for review April 17, 2020 15:49
@chrisdrackett
Copy link
Contributor Author

so this takes care of the core stuff, but now the issue is that react native is still going to try and use the browser version of any plugin. As most of these include web only code is still isn't possible to track anything in react native. Curious if you have thoughts on the best way forward here, I'm still a little fuzzy on how the decision on which of this files to use is made

@DavidWells
Copy link
Owner

Just tested this out. Looks good.

Going to merge and release for ya.

I'm still trying to get to the bottom of whats up with React native using browser version of the module 😃https://twitter.com/DavidWells/status/1252422868027142157

@DavidWells
Copy link
Owner

react native is still going to try and use the browser version of any plugin

Ah yeah good point... still need to figure out

@DavidWells DavidWells merged commit 2c6a97a into DavidWells:master Apr 21, 2020
@DavidWells
Copy link
Owner

Ok updated to support in analytics@0.3.5

Also, typescript types are now republished 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants