Changes for SQL Server support #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vert.x Snapshots are published to the Sonatype's new infra for OSS projects. This allow to run tests with, for example '-PenableSonatypeOpenSourceSnapshotsRep -PvertxVersion=4.1.0-SNAPSHOT'
tsegismont
force-pushed
the
mssql-vertx-4
branch
from
5e3f589
to
a6abbc1
Compare
|
Thanks, I will try this soon |
SQL Server expects variables/parameters to begin with the [at] sign
tsegismont
changed the title
|
Hey @tsegismont, sorry, we had some issues on reactive and I hadn't had the time to look into this. Now that we have release Reactive CR4 we should be able to get back to it. Thanks a lot for the help. |
|
No worries!
Le ven. 30 avr. 2021 à 18:33, DavideD ***@***.***> a écrit :
… Hey @tsegismont <https://github.com/tsegismont>, sorry, we had some
issues on reactive and I hadn't had the time to look into this. Now that we
have release Reactive CR4 we should be able to get back to it. Thanks a lot
for the help.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALOLNT7XCV7PH32G5OYILLTLLLULANCNFSM42E5B4QA>
.
|
Fixes hibernate#743 SQL Server understands neither temporary nor local/global keywords. Instead, it expects temporary local table names to begin with '#", global with '##'.
tsegismont
changed the title
|
THanks @tsegismont ! I've rebased this on a new branch that I will push on |
|
@DavideD great! Which is the new branch? |
|
I haven't pushed it yet upstream as I'm checking that everything is alright. |
|
This is the branch: https://github.com/hibernate/hibernate-reactive/tree/wip/mssql |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review each commit separetely.