Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workflow for testing the latest Vert.x SQL client snapshots #698

Closed
DavideD opened this issue Apr 12, 2021 · 6 comments · Fixed by #741
Closed

Create workflow for testing the latest Vert.x SQL client snapshots #698

DavideD opened this issue Apr 12, 2021 · 6 comments · Fixed by #741
Assignees
Labels
testing Improvements to test suite upgrade Impact of dependency upgrades

Comments

@DavideD
Copy link
Member

DavideD commented Apr 12, 2021

See DavideD#13

@gbadner
Copy link
Contributor

gbadner commented May 4, 2021

@gavinking, I'm unclear about what is expected for this task. I have not worked on github workflows before so I have some newby questions about how to move forward.

I am currently working on a branch off of main.

I've cherry-picked @tsegismont's commit so Vert.x snapshots can be enabled.

In order for the workflow to use Vert.x 4.1.0-SNAPSHOT, should vertxVersion be changed to 4.1.0-SNAPSHOT in build.gradle, or should I set matrix.vertx-version to 4.1.0-SNAPSHOT in tracking-vertx-4.build.yml itself?

I know I need to add -PenableSonatypeOpenSourceSnapshotsRep to the gradle command.

I plan to add what is needed for db2 to the workflow. I will wait until a good point to sync up with Thomas' work for SQL Server before adding it to the workflow.

@gavinking
Copy link
Member

I'm unclear about what is expected for this task.

@gbadner well, me too.

You need to ask @DavideD, who I heard a rumor is on vacation or something.

@gbadner
Copy link
Contributor

gbadner commented May 4, 2021

I was trying not to bother Davide. I'll just wing it for now.

@DavideD
Copy link
Member Author

DavideD commented May 4, 2021 via email

@gbadner
Copy link
Contributor

gbadner commented May 4, 2021

@DavideD, thank you for that tip. I think I get it now!

@DavideD
Copy link
Member Author

DavideD commented May 10, 2021

Done, thanks!

@DavideD DavideD closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements to test suite upgrade Impact of dependency upgrades
Projects
None yet
3 participants