-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create workflow for testing the latest Vert.x SQL client snapshots #698
Comments
@gavinking, I'm unclear about what is expected for this task. I have not worked on github workflows before so I have some newby questions about how to move forward. I am currently working on a branch off of main. I've cherry-picked @tsegismont's commit so Vert.x snapshots can be enabled. In order for the workflow to use Vert.x 4.1.0-SNAPSHOT, should I know I need to add I plan to add what is needed for db2 to the workflow. I will wait until a good point to sync up with Thomas' work for SQL Server before adding it to the workflow. |
I was trying not to bother Davide. I'll just wing it for now. |
Yes, that was the idea. Evaluate if we can start building with it and then
add it it to the build on CI. If you check the Hibernate ORM one, we do the
same thing with Orm 5.4 and 5.5. Vertex should do a similar thing:
https://github.com/hibernate/hibernate-reactive/blob/380a4e3888e8340042e552e4ad8ec1db232f21a1/.github/workflows/tracking-orm-5.build.yml#L25
But if it's too soon, we can wait. It might be still worth it to enable the
snapshots repository for testing the latest 4.0.0-SNAPSHOT
…On Tue, 4 May 2021, 19:43 Gavin King, ***@***.***> wrote:
I'm unclear about what is expected for this task.
@gbadner <https://github.com/gbadner> well, me too.
You need to ask @DavideD <https://github.com/DavideD>, who I heard a
rumor is on vacation or something.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#698 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEIQ5LG4MWWEJKS6PDGM3DTMA53ZANCNFSM42Y5A22A>
.
|
@DavideD, thank you for that tip. I think I get it now! |
Done, thanks! |
See DavideD#13
The text was updated successfully, but these errors were encountered: