Add japanese character filter #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a filter, which uses japanese hiraganas to display the pixels. (Add japanese.py) See #69
Davidy22
requested changes
Oct 12, 2021
| def filter( | ||
| self, image: List[List[Tuple[int, int, int, int]]]) -> List[List[Tuple[int, int, int, int]]]: | ||
| """Process an ASCII image and return an image of the same format and dims""" | ||
| symbols = ['あ', 'い', 'う', 'え', 'お', 'か', 'き', 'く', 'け', 'こ', 'さ', 'し', 'す', 'せ', 'そ', 'た', 'ち', 'つ', 'て', 'と', |
There was a problem hiding this comment.
len() and indexing also work on strings, and I think you'll find that doing this on a single string performs a bit faster.
| symbols = ['あ', 'い', 'う', 'え', 'お', 'か', 'き', 'く', 'け', 'こ', 'さ', 'し', 'す', 'せ', 'そ', 'た', 'ち', 'つ', 'て', 'と', | ||
| 'な', 'に', 'ぬ', 'ね', 'の', 'は', 'ひ', 'ふ', 'へ', 'ほ', 'ま', 'み', 'む', 'め', 'も', 'や', 'ゆ', 'よ', 'ら', 'り', | ||
| 'る', 'れ', 'ろ', 'わ', 'を'] | ||
| return [[(symbols[randint(0, len(symbols))], j[1], j[2], 0) for j in i] for i in image] |
There was a problem hiding this comment.
I know a lot of the existing filters are context free character substitutions, I probably didn't set the best precedent by approving all those filters that only replace the whole screen with one character, but it'd be kinda nice if newer ones pushed the boundaries a little and did some sort of shade thing like I did with the newer shovels filter
Davidy22
reviewed
Oct 12, 2021
| """ | ||
| self.textOp = True | ||
| self.name = "Japanese" | ||
| self.description = "Fill the image with random japanese letters" |
There was a problem hiding this comment.
I think letters is a european alphabet name, think these are characters.
|
Closing because doesn't work and doesn't look like this is going to get fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a filter, which uses japanese hiraganas to display the pixels. (Add japanese.py)
See #69