Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] Game freezes if you equip certain Construct's Armory Pieces with different traits if Tinkers Leveling is installed. #147

Closed
SonicX8000 opened this issue Apr 23, 2019 · 15 comments
Labels
(╯°□°)╯︵ ┻━┻ wtf?!?!? bug Something isn't working

Comments

@SonicX8000
Copy link

SonicX8000 commented Apr 23, 2019

Describe the bug
Attempting to wear certain Construct's Armory pieces with different traits will cause the game to freeze. Only way to exit is to kill the process via task manager.

To Reproduce

  1. Equip two pieces of all Kalendrite OR Amorine with the trait 'Strength'. Game will freeze upon equipping the second piece.

  2. Equip something such as a Manyullyn Leggins (Manyullun Leggins Core, Steel Plates and Cobalt Trim.) These grant 'Vengeful', 'Indomitable' and 'Lightweight' traits. Game will freeze upon equipping them.

Expected behavior
The game not freezing.

Versions:

  • Metallurgy 4: Reforged: 0.2.0
  • Forge: 14.23.5.2836
  • Minecraft: 1.12.2
  • Conflicting mod (if regarding mod integration): TinkerToolLeveling-1.12.2-1.1.0

Additional context
Unsure if Modifiers could also cause a freeze to happen. No crash occurs so it's just a complete lock-up with no crash report. The log doesn't appear to say anything when the freeze occurs.

If either Metallurgy or Tinker's Tool Leveling are used by themselves... the game will not freeze while equipping certain armor pieces.

Mod List:
conarm-1.12.2-1.2.3.3
Mantle-1.12-1.3.3.49
Metallurgy-4-Reforged-0.2.0
TConstruct-1.12.2-2.12.0.135
TinkerToolLeveling-1.12.2-1.1.0

@SonicX8000 SonicX8000 added bug Something isn't working needs verification test/debug needed labels Apr 23, 2019
@Davoleo Davoleo added (╯°□°)╯︵ ┻━┻ wtf?!?!? help wanted Extra attention is needed and removed needs verification test/debug needed labels Apr 23, 2019
@Davoleo
Copy link
Owner

Davoleo commented Apr 23, 2019

Ok, I was able to reproduce this in my dev environment, but rn I'm quite unsure of what is going wrong :P

It's a really weird bug, especially because you don't get any log info, or any kind of errors

We'll further look into this for sure though, thanks for reporting
(PS: if you get some more info that you think might help us to sort this out feel free to add it here!)

@Syphenion
Copy link

Syphenion commented Apr 23, 2019

Yeah that's the same bug I had previously, but I didn't have TinkerToolLeveling. Just Conarm 1.2.3.3 and Metallurgy-4-Reforged-0.2.0

@Davoleo
Copy link
Owner

Davoleo commented Apr 23, 2019

mmh, however @Z-Tunic has said this bug doesn't seem to be reproduceable if you remove Tinkers Tool Leveling 🤔
@Syphenion

@SonicX8000
Copy link
Author

SonicX8000 commented Apr 23, 2019

I tried without TinkerToolLeveling and was able to equip the mentioned armors without any freezes. Unless there's certain other armors that cause a freeze that isn't related to TinkerToolLeveling?

Speaking of which, I forgot to update ConArm to a later version "conarm-1.12.2-1.2.3.4". Did just that and tried the steps again. Still get the same freeze when trying to wear... say two pieces of ConArm Kalendrite Armor with 'Strength' but if I remove TinkersToolLeveling? No freeze. If I remove Metallurgy instead of TinkersToolLeveling? No freeze.


Alrighty... so if you wear an all-Kalendrite, all-Steel piece, all-Manyullyn piece, and a all-Cobalt piece (Kalendrite Helm, Steel Chestplate, Manyullyn Leggings, and Cobalt Boots. Traits: Strength, Steady, Indomitable, Vengeful, Prideful, Featherweight, and Lightweight). No freeze occurs when wearing the pieces together.

Now if I mix the parts into one armor piece. Let's just say a Manyullyn Chestplate Core, Steel Plates, and Cobalt Trim. (Vengeful, Lightweight, and Indomitable). Game freezes.

Perhaps maybe it doesn't like it when the parts are mixed up? Then again why would Strength alone freeze? Unless it tries to apply a Strength II instead of Strength I? The info for the 'Strength' trait says it may apply either Strength I or Strength II.

@Davoleo
Copy link
Owner

Davoleo commented Apr 23, 2019

uh, thanks for investigating more into this

@Davoleo
Copy link
Owner

Davoleo commented Apr 23, 2019

this kind of freeze with no errors however makes me think it should be stuck in some while/for loop

@SonicX8000
Copy link
Author

SonicX8000 commented Apr 23, 2019

@Syphenion
I tried an all-Steel Chestplate with the 'Traveler's Cloak (Slowfall)' and that too causes a freeze, even if TinkersToolLeveling isn't installed so I guess certain modifiers can apparently cause a freeze to happen.

This freeze doesn't occur if I put the Traveler's Cloak (Slowfall) on a all-Cobalt Chestplate since Cobalt is from Vanilla Tinkers. Now I'm really puzzled with this.

@Davoleo
Copy link
Owner

Davoleo commented Apr 23, 2019

ok so this is related to #142

I'll talk with @HurtsAsHell about this asap

@Davoleo Davoleo added needs verification test/debug needed and removed help wanted Extra attention is needed labels Apr 23, 2019
@slushieboy99
Copy link

Let me know when this is patched, I am also having this issue

@HurtsAsHell
Copy link
Collaborator

When the 2.1 will be released it will be fixed

Let me know when this is patched, I am also having this issue

@slushieboy99
Copy link

Thanks! I'll keep an eye out for that.

@ReducoGD
Copy link

ReducoGD commented May 1, 2019

I had the same problem, but with other parts:
-Krik plates.
-Lutetium armor cores.
-Amordine trims.

I guessed that the freezing was caused by the armor pieces being equipped, each one trying to apply the Strength II effect on the player (because of the Amordine trims's trait).

@Davoleo Davoleo added fixed/implemented in dev and removed needs verification test/debug needed labels May 1, 2019
@HurtsAsHell HurtsAsHell pinned this issue May 3, 2019
@Davoleo Davoleo added this to TO DO in Dev Workflow via automation May 4, 2019
@Davoleo Davoleo moved this from TO DO to In progress in Dev Workflow May 4, 2019
@ghost
Copy link

ghost commented May 7, 2019

I can confirm that this type of bug happens without tinkers tool leveling as well.

The way I did it was having one of the armor cores (it doesn't matter it can be the helmet, chest plate, leggings, or boots) that is made of slime, and then any Construct's Armory pieces (it doesn't matter what the trim material or plate material is) that has a slime core piece, upon equipping it, the game will freeze without producing a crash log, and you can only kill it by spamming the x button on the tab or killing it with task manager. This freeze still also occurs when integration with Construct's Armory is disabled in the metallurgy configs.

Example armor that crashed/froze: Slime Boot Core, Iron trim and Plates

This is with versions:
Metallurgy-4-Reforged-0.2.0
conarm-1.12.2-1.2.3.4

Dev Workflow automation moved this from In progress to Done May 28, 2019
@ekoman93
Copy link

it also freezes when I mixed wood and stone parts for any of the pieces
stone cores and trim with wood plates

@Davoleo
Copy link
Owner

Davoleo commented May 29, 2019

yep, it's fixed in our dev version, it'll be fixed as soon as we publish a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(╯°□°)╯︵ ┻━┻ wtf?!?!? bug Something isn't working
Projects
No open projects
Dev Workflow
  
Done
Development

No branches or pull requests

7 participants