[5.2.1] | Fix SqlConnection.FireInfoMessageEventOnUserErrors when set…

… to true throws an exception (dotnet#2399)
DavoudEshtehari · May 16, 2024 · c2bca36 · c2bca36
1 parent 82be9a6
commit c2bca36
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs
@@ -6776,7 +6776,7 @@ internal SqlBatchCommand GetCurrentBatchCommand()
             }
             else
             {
-                return _rpcArrayOf1[0].batchCommand;
+                return _rpcArrayOf1?[0].batchCommand;
             }
         }
 

diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs
@@ -7487,7 +7487,7 @@ internal SqlBatchCommand GetCurrentBatchCommand()
             }
             else
             {
-                return _rpcArrayOf1[0].batchCommand;
+                return _rpcArrayOf1?[0].batchCommand;
             }
         }
 

diff --git a/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/ConnectivityTest.cs b/src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ConnectivityTests/ConnectivityTest.cs
@@ -474,5 +474,29 @@ public static void SqlPasswordConnectionTest()
             using SqlConnection sqlConnection = new(b.ConnectionString);
             sqlConnection.Open();
         }
+
+        [ConditionalFact(typeof(DataTestUtility), nameof(DataTestUtility.AreConnStringsSetup), nameof(DataTestUtility.IsNotAzureSynapse))]
+        public static void ConnectionFireInfoMessageEventOnUserErrorsShouldSucceed()
+        {
+            using (var connection = new SqlConnection(DataTestUtility.TCPConnectionString))
+            {
+                string command = "print";
+                string commandParam = "OK";
+
+                connection.FireInfoMessageEventOnUserErrors = true;
+
+                connection.InfoMessage += (sender, args) =>
+                {
+                    Assert.Equal(commandParam, args.Message);
+                };
+
+                connection.Open();
+
+                using SqlCommand cmd = connection.CreateCommand();
+                cmd.CommandType = System.Data.CommandType.Text;
+                cmd.CommandText = $"{command} '{commandParam}'";
+                cmd.ExecuteNonQuery();
+            }
+        }
     }
 }