Rails 5 compatibility

[tagliala]

• Make all ruby tests pass
• Make all javascript tests pass
• Use Method#prepend instead of alias_method_chain
• Add javascript support for case insensitive confirmation validator
• Wait for a rack >= 2.0.0 compatible version of Sinatra

[tagliala]

It should be done, please giva a try to

gem 'client_side_validations', github: 'DavyJonesLocker/client_side_validations', branch: 'rails5'

[SebDE]

It worked perfekt for me - many thanks ! Just no problem with the simple-form-plugin (only small deprecated warning)

[tagliala]

@SebDE 'cause the simple-form plugin still makes use of alias_method_chain, I will start a new branch there

[arturatns]

Single error was found in the form submit when validating the first time and an error occurs, it is not possible to send the form again

[tagliala]

does this happen only on rails5?

[SebDE]

@arturtuii can you post a example of the behaviour or the code - i just tested with my application (under Rails 5) and I'm able to submit the form every time without problems - if there are no validation errors.

If you have the problem within your project (igopizzas) - i looked at your sign-in form (there are client-side-validations used) and found the following error if i try to submit the form:

Uncaught RangeError: Maximum call stack size exceeded

The error comes from jquery and I think you have a problem with a recursive call in javascript and not with client-side-validations ...

[arturatns]

Found error now, occurred in rails.validations.custom. This working perfectly, very good this release.

[tagliala]

glad to hear that 👍

[edwardmp]

Thanks for publishing this. Tried It out today but it doesn't seem to work due to the following javascript error:
rails.validations.js?body=1:188 Uncaught TypeError: Cannot read property 'remove' of undefined

[tagliala]

@edwardmp please start a new issue providing all the information needed and a reduced test case: https://github.com/DavyJonesLocker/client_side_validations/blob/master/CONTRIBUTING.md#submitting-a-new-issue

[dreyks]

What's the status on this one?

[tagliala]

@dreyks thanks for the ping.

I'm not going to release a gem in a short while, so please keep using the rails5 branch

Also, sinatra is still on beta. If we could drop the sinatra thing and run javascript unit tests against a Node.JS based server (and maybe make that work on Travis), it would be great.

That release should be implemented on the current master branch because it will benefit the Rails 4 version too

[tagliala]

Master branch is now compatible with Rails 5.

Expect a new release very soon.

Version will be 6.0.0, I will jump 5.x because now CSV will follow its own versioning for proper SemVer

[tagliala]

CSV 6.0.0 released. I'm going for CSV-simple_form

[dreyks]

Great news! Highly appreciated, thanks!

[rubydev]

@tagliala Hi, could you please update CSV-mongoid for this version (and mongoid 6 and rails 5)?

[tagliala]

@rubydev I will give it a try, it is the next on the list!

btw you could give a try to https://github.com/DavyJonesLocker/client_side_validations-mongoid/tree/6-0-dev

[tagliala]

@rubydev CSV-Mongoid 7.0.0 released