Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue of removing error message #607

Closed
wants to merge 1 commit into from
Closed

fixed issue of removing error message #607

wants to merge 1 commit into from

Conversation

adityashankert
Copy link

if there are more than 2 classes for error field div class then if the error message is displayed it will not go if the user corrects the field

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.29% when pulling fca070f on adityashankert:master into 366198b on DavyJonesLocker:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.29% when pulling fca070f on adityashankert:master into 366198b on DavyJonesLocker:master.

@tagliala
Copy link
Contributor

Hi,

thanks for this PR but there are a couple of issues:

  1. You should edit the coffee file and recompile the javascript via rake regenerate_javascript
  2. You should add a failing unit test that your PR is going to fix, or give me hints so I can reproduce the bug and write a proper test

Let me know if you need further assistance

@adityashankert
Copy link
Author

Hi,

I don't know how to write tests i can tell you to reproduce it can you write the tests? i will do the coffee script thing and create a new pull request will it do?

@adityashankert
Copy link
Author

I am closing this pull request and will raise new one

@tagliala
Copy link
Contributor

@adityashankert yes, tell me how to reproduce I will try to write a failing unit test

@adityashankert
Copy link
Author

@tagliala #608 check this new pull request I have written the reproduction steps there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants