Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.2.0 #152

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Release v2.2.0 #152

merged 1 commit into from
Oct 19, 2021

Conversation

MrChocolatine
Copy link
Member

Build

Bump eslint-plugin-ember from 10.5.5 to 10.5.7 (#150)

Bump @types/ember__object from 3.12.5 to 3.12.6 (#151)

CI

Replace test scenario ember-lts-3.24 with ember-lts-3.16 (#148)

At the time of writing these changes, the add-on already runs with ember-cli@3.24 so testing the LTS v3.24 in the CI does not make sense.

Follow the native implementation of Ember.js:

Documentation

Lower compatible version of Ember.js (#148)

Because the CI will test against Ember.js v3.16, we should mention the add-on is compatible with this version.

Add a section about TypeScript support (#149)

Features

Allow to pass type of embedded options to Service embedded (#149)

The Service embedded now accepts a generic type parameter to improve the accuracy of what it can return.

import Component from '@glimmer/component';
import { inject as service } from '@ember/service';

import type EmbeddedService from 'ember-cli-embedded/services/embedded';

export default class MyComponent extends Component {
  @service
  declare embedded: EmbeddedService<{ one: string, two?: string }>;

  get one() { // Return type inferred: `string | undefined`
    return this.embedded.get('one');
  }

  get two() {
    // TypeScript returns an error as `twoo` is not a recognised key
    return this.embedded.get('twoo');
  }
}

Fixes

Fix required versions of Node.js (#148)

Node.js v10 is actually not supported so we should not mention it in our package.json.

Refactor

Update Service embedded to native JS class (#149)

Make tests of Service embedded stricter (#149)

Prefer assert.strictEqual() over assert.equal().

@MrChocolatine MrChocolatine requested a review from a team as a code owner October 19, 2021 12:46
@MrChocolatine MrChocolatine merged commit 567aa42 into master Oct 19, 2021
@MrChocolatine MrChocolatine deleted the build-release-v2.2.0 branch October 19, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants