Fix requirements and CI tests #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrChocolatine
added
ci
MrChocolatine
changed the title
ndekeister-us
approved these changes
Oct 14, 2021
MrChocolatine
force-pushed
the
fix-requirements-and-ci-tests
branch
from
7c68af8
to
8ce68d1
Compare
The reason for chosing this semver format is to follow the update made in `ember-cli` v3.28: https://github.com/ember-cli/ember-addon-output/blob/v3.28.2/package.json#L70 ``` "node": "12.* || 14.* || >= 16" ```
MrChocolatine
force-pushed
the
fix-requirements-and-ci-tests
branch
from
8ce68d1
to
70707d8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI
Replace test scenario
ember-lts-3.24withember-lts-3.16(#148)At the time of writing these changes, the add-on already runs with
ember-cli@3.24so testing the LTS v3.24 in the CI does not make sense.Follow the native implementation of Ember.js:
Documentation
Lower compatible version of Ember.js (#148)
Because the CI will test against Ember.js v3.16, we should mention the add-on is compatible with this version.
Fixes
Fix required versions of Node.js (#148)
Node.js v10 is actually not supported so we should not mention it in our
package.json.