Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide overloads to specify MySql schema to use in extensions #185

Merged
merged 2 commits into from Apr 9, 2016

Conversation

mgkeen
Copy link
Contributor

@mgkeen mgkeen commented Apr 5, 2016

When multiple schemas existed, it checked for any table named schemaversions in any schema.
Query code was already in place to be specific about schema, but not exposed via extensions.

@chriswithpants
Copy link
Contributor

Build failed 😞

@mgkeen
Copy link
Contributor Author

mgkeen commented Apr 6, 2016

Build failure appears to be because i added to the public API and it needs approval. Don't want to go and change the "approved" file myself. I assume @JakeGinnivan needs to do this?

@JakeGinnivan
Copy link
Member

@mgkeen you can approve no worries.

The check is there so if you change the public API you can visualise that change and make sure it is not a breaking change.

@JakeGinnivan
Copy link
Member

This change is just adding overloads, so it's fine to accept the change because there are no breaking changes.

@mgkeen
Copy link
Contributor Author

mgkeen commented Apr 6, 2016

Updated. Really like that way of visualising API changes. Been looking for something that simple.

@JakeGinnivan
Copy link
Member

https://github.com/JakeGinnivan/ApiApprover is the project :)

@JakeGinnivan JakeGinnivan merged commit 6002f2e into DbUp:master Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants