Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide overloads to specify MySql schema to use in extensions #185

Merged
merged 2 commits into from Apr 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 28 additions & 1 deletion src/DbUp.MySql/MySqlExtensions.cs
Expand Up @@ -25,6 +25,20 @@ public static UpgradeEngineBuilder MySqlDatabase(this SupportedDatabases support
return MySqlDatabase(new MySqlConnectionManager(connectionString));
}

/// <summary>
/// Creates an upgrader for MySql databases.
/// </summary>
/// <param name="supported">Fluent helper type.</param>
/// <param name="connectionString">MySql database connection string.</param>
/// <param name="schema">Which MySql schema to check for changes</param>
/// <returns>
/// A builder for a database upgrader designed for MySql databases.
/// </returns>
public static UpgradeEngineBuilder MySqlDatabase(this SupportedDatabases supported, string connectionString, string schema)
{
return MySqlDatabase(new MySqlConnectionManager(connectionString), schema);
}

/// <summary>
/// Creates an upgrader for MySql databases.
/// </summary>
Expand All @@ -33,11 +47,24 @@ public static UpgradeEngineBuilder MySqlDatabase(this SupportedDatabases support
/// A builder for a database upgrader designed for MySql databases.
/// </returns>
public static UpgradeEngineBuilder MySqlDatabase(IConnectionManager connectionManager)
{
return MySqlDatabase(connectionManager, null);
}

/// <summary>
/// Creates an upgrader for MySql databases.
/// </summary>
/// <param name="connectionManager">The <see cref="MySqlConnectionManager"/> to be used during a database upgrade.</param>
/// /// <param name="schema">Which MySQL schema to check for changes</param>
/// <returns>
/// A builder for a database upgrader designed for MySql databases.
/// </returns>
public static UpgradeEngineBuilder MySqlDatabase(IConnectionManager connectionManager, string schema)
{
var builder = new UpgradeEngineBuilder();
builder.Configure(c => c.ConnectionManager = connectionManager);
builder.Configure(c => c.ScriptExecutor = new SqlScriptExecutor(() => c.ConnectionManager, () => c.Log, null, () => c.VariablesEnabled, c.ScriptPreprocessors));
builder.Configure(c => c.Journal = new MySqlITableJournal(() => c.ConnectionManager, () => c.Log, null, "schemaversions"));
builder.Configure(c => c.Journal = new MySqlITableJournal(() => c.ConnectionManager, () => c.Log, schema, "schemaversions"));
builder.WithPreprocessor(new MySqlPreprocessor());
return builder;
}
Expand Down
2 changes: 2 additions & 0 deletions src/DbUp.Tests/DbUp.MySql.approved.cs
Expand Up @@ -31,5 +31,7 @@ public class MySqlPreprocessor : DbUp.Engine.IScriptPreprocessor
public class static MySqlExtensions
{
public static DbUp.Builder.UpgradeEngineBuilder MySqlDatabase(this DbUp.Builder.SupportedDatabases supported, string connectionString) { }
public static DbUp.Builder.UpgradeEngineBuilder MySqlDatabase(this DbUp.Builder.SupportedDatabases supported, string connectionString, string schema) { }
public static DbUp.Builder.UpgradeEngineBuilder MySqlDatabase(DbUp.Engine.Transactions.IConnectionManager connectionManager) { }
public static DbUp.Builder.UpgradeEngineBuilder MySqlDatabase(DbUp.Engine.Transactions.IConnectionManager connectionManager, string schema) { }
}