Dev twindad #33
Open
Dev twindad #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Inglenook Game class
Working version of LCDThrottle
…ng press of Select
…iThrottle. NOTE: Compiles, but may not execute. Not tested.
NOTE: Turnout control does not yet work right, in that the throttle doesn't show the turnouts. Still debugging that. Also, having a static table of turnout addresses compiled into the code seems a bit of a hack. Cleaned up some comments etc. as well. Switched to DHCP-assigned address.
…ed()) and while(client.available()) conditions in the input loop in SerialCommand This helps with when to send the welcome message and keeps things a bit more clean. Should have no effect on normal Ethernet connections. If it does have an adverse effect, we can always put the variant while() constructs inside a compiler directive. 2) Fixed the Track Power control 3) Fixed the direction control on the throttle.
Also removed the line from printIntroMessage() that was a compile-time error.
2) Added support for Bonjour/Zeroconf registration. Disabled in Config.h WARNING: If using the EthernetBonjour library (which this does), you MUST make the changes to the Ethernet library as outlined in this Arduino forum thread: http://forum.arduino.cc/index.php?topic=234340.0 ALSO, you must change line 148 of EthernetBonjour.cpp to call this->beginMulti() instead of this->beginMulticast() ... apparently a typo still in the library. FINALLY, you might want to change #define HAS_NAME_BROWSING in EthernetBonjour.cpp to 0, to save some space, since we are registering a service, not browsing for one. I have not (yet) tested that though.
Indicates to JMRI that current feedback is not supported. Suppresses the 308 error that occurs when using DCC++ with a motor shield that doesn't support feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "-2" response to the programming track Writes. This is sent when MOTOR_SHIELD_SUPPORTS_FEEDBACK = 0
This will supporess the spurious 308 error message in JMRI when using DCC++ with a motor shield that does not have current feedback.