Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Boost to 1.75 #1154

Merged
merged 4 commits into from
Mar 30, 2022
Merged

Update Boost to 1.75 #1154

merged 4 commits into from
Mar 30, 2022

Conversation

Bushstar
Copy link
Member

No description provided.

bvbfan
bvbfan previously approved these changes Mar 22, 2022
@prasannavl
Copy link
Member

What are your thoughts to lower it to 1.75 for now? They resolve the header but also don't break anything else - and then move to 1.77/1.78 for v3 resolving these.

@bvbfan
Copy link
Contributor

bvbfan commented Mar 30, 2022

v3 is moved to 1.77, you can lowered as you want.

@prasannavl
Copy link
Member

Also might need to do something like:

$(package)_version_dot=$(subst _,.,$($(package)_version))
$(package)_download_path=https://boostorg.jfrog.io/artifactory/main/release/$($(package)_version_dot)/source/

The current ones fails due to the _ / . difference in versions, and fallsback to bitcoin org repository.

@prasannavl prasannavl changed the title Update Boost to 1.77 Update Boost to 1.75 Mar 30, 2022
@prasannavl
Copy link
Member

Lowered to 1.75 for now. Let's move to 1.77 on v3 after resolving the warnings.

@bvbfan bvbfan self-requested a review March 30, 2022 08:12
@prasannavl prasannavl merged commit 76144f3 into master Mar 30, 2022
@prasannavl prasannavl deleted the update-boost-1.77 branch March 30, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants