Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICX feature flag. Fix bug on mainnet. #2059

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Add ICX feature flag. Fix bug on mainnet. #2059

merged 8 commits into from
Jun 19, 2023

Conversation

Mixa84
Copy link
Contributor

@Mixa84 Mixa84 commented Jun 13, 2023 •
edited by prasannavl
Loading

Summary

  • Add ICX feature flag in attributes
  • Fix makerBonus bug on mainnet (it was fixed for testnet and regtest already)

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None

  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Mixa84 Mixa84 added the v/next-network-upgrade Items ready or targeted for upcoming network upgrade release(s) label Jun 13, 2023
@Mixa84 Mixa84 self-assigned this Jun 13, 2023
Bushstar
Bushstar previously approved these changes Jun 13, 2023
View reviewed changes
@Bushstar Bushstar merged commit 7c9f749 into master Jun 19, 2023
7 of 10 checks passed
@Bushstar Bushstar deleted the feature/icx_feature_flag branch June 19, 2023 10:16
Bushstar added a commit that referenced this pull request Jun 21, 2023
@Bushstar
Update for #2059 after merge
7333489
@thedoublejay thedoublejay mentioned this pull request Jun 21, 2023
Merged
thedoublejay added a commit to BirthdayResearch/jellyfishsdk that referenced this pull request Jun 28, 2023
@thedoublejay
chore(ops): updated node to v4.0.0-beta4 (#2108)
9a2fa9b 
<!--  Thanks for sending a pull request! -->

#### What this PR does / why we need it:
1. Updates node to
https://github.com/DeFiCh/ain/releases/tag/v4.0.0-beta4
2. Set ICX feature flag - DeFiCh/ain#2059

#### Which issue(s) does this PR fixes?:
<!--
(Optional) Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Fixes #

#### Additional comments?:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannavl prasannavl prasannavl left review comments

@Bushstar Bushstar Bushstar approved these changes

Assignees

@Mixa84 Mixa84

Labels
v/next-network-upgrade Items ready or targeted for upcoming network upgrade release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mixa84 @prasannavl @Bushstar