Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC: Fix eth_feeHistory pipeline #2784

Merged
merged 15 commits into from
Jan 22, 2024
Merged

RPC: Fix eth_feeHistory pipeline #2784

merged 15 commits into from
Jan 22, 2024

Conversation

sieniven
Copy link
Member

@sieniven sieniven commented Jan 17, 2024

Summary

  • PR contains the fixes to correct the erroneous fee_history pipeline.
  • Check block range argument limits passed in the RPC.
  • Check priority fee percentile vector to be monotonically increasing and not exceed max vec size limit.
  • Proper priority fee calculation from the block transactions, taking to account the block base fee and the maxFeePerGas limit set for EIP1559 transactions.
  • Proper priority fee calculation for non-EIP1559 transactions (gasPrice - block base fee).
  • Clean up and add more test coverage to feature_evm_rpc_fee_history functional test.

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

lib/ain-evm/src/block.rs Outdated Show resolved Hide resolved
@sieniven sieniven requested a review from Jouzo January 22, 2024 08:17
@Jouzo Jouzo enabled auto-merge January 22, 2024 11:39
@Jouzo Jouzo disabled auto-merge January 22, 2024 13:00
@Jouzo Jouzo merged commit c7946cd into master Jan 22, 2024
15 of 16 checks passed
@Jouzo Jouzo deleted the niven/fix-fee-history branch January 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants