New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clojure CLI downloads are moving to Github releases #88
Comments
Hi @puredanger ! New release 12.0 is available right now, but there is one problem I encountered after I merged the PR – some releases do not follow the convention you described in the issue. Here is a failed run for example - https://github.com/DeLaGuardo/setup-clojure/actions/runs/6099035886/job/16550246440 |
This is only for releases since 1.11.1.1379. I have backfilled some older releases to help some other projects migrate but no guarantees on anything older than 1.11.1.1379. |
The last 4 is an always increasing number, so checking just that last segment is sufficient to compare versions. |
I think it would be better to check the release description if expected assets are in there. I'm using that API anyway. |
I am preparing to move primary Clojure CLI downloads to Github releases. While I will continue publishing to download.clojure.org as a backup, Github should become the primary. This will require some changes in setup-clojure in cli.ts:
The latter two will now vary depending on when we've started publishing releases, so you can either do that with 1.11.1.1379 as the boundary or (better?) trying the github urls, then failing over to the download url. The brew recipe is being set up this way as well. Please let me know if you have any questions or find anything interesting while making this change.
The text was updated successfully, but these errors were encountered: